FindBugs Results

The following document contains the results of FindBugs.

Summary

Files Errors
26 38

Files

Files Violations
net.sf.statcvs.model.SymbolicName 3
net.sf.statcvs.model.Revision 3
net.sf.statcvs.model.Author 1
net.sf.statcvs.model.VersionedFile 1
net.sf.statcvs.model.Directory 1
net.sf.statcvs.model.Repository 2
net.sf.statcvs.util.IntegerMap$SortByValueComparator 1
net.sf.statcvs.util.IntegerMap 1
net.sf.statcvs.charts.TimeBarChartMaker 1
net.sf.statcvs.model.Commit 1
net.sf.statcvs.charts.LOCChartMaker$AllDirectoriesLOCChartMaker 1
net.sf.statcvs.input.RevisionData 3
net.sf.statcvs.input.RepositoryFileManager 2
net.sf.statcvs.input.Builder 1
net.sf.statcvs.output.CommandLineParser 2
net.sf.statcvs.charts.CommitScatterChartMaker 1
net.sf.statcvs.reportmodel.HelperTimePoint 1
net.sf.statcvs.reportmodel.TimePoint 2
net.sf.statcvs.reports.FilesRevisionCountComparator 1
net.sf.statcvs.reports.FilesLocComparator 1
net.sf.statcvs.pages.xml.AllDevelopersXml 1
net.sf.statcvs.pages.xml.FilesXml 3
net.sf.statcvs.pages.xml.GenerateXml 1
net.sf.statcvs.Main 1
net.sf.statcvs.input.CvsRevisionParser 1
net.sf.statcvs.reports.LOCSeriesBuilder 1

net.sf.statcvs.model.SymbolicName

Violation Line Priority
RCN: Redundant nullcheck of obj, which is known to be non-null in net.sf.statcvs.model.SymbolicName.equals(Object) 126 Normal
EI2: net.sf.statcvs.model.SymbolicName.SymbolicName(String, Date) may expose internal representation by storing an externally mutable object into SymbolicName.date 45 Normal
EI: net.sf.statcvs.model.SymbolicName.getDate() may expose internal representation by returning SymbolicName.date 93 Normal

net.sf.statcvs.model.Revision

Violation Line Priority
Eq: net.sf.statcvs.model.Revision defines compareTo(Object) and uses Object.equals() 292 Normal
EI2: net.sf.statcvs.model.Revision.Revision(VersionedFile, String, int, Author, Date, String, int, int, int, SortedSet) may expose internal representation by storing an externally mutable object into Revision.date 106 Normal
EI: net.sf.statcvs.model.Revision.getDate() may expose internal representation by returning Revision.date 154 Normal

net.sf.statcvs.model.Author

Violation Line Priority
Eq: net.sf.statcvs.model.Author defines compareTo(Object) and uses Object.equals() 91 Normal

net.sf.statcvs.model.VersionedFile

Violation Line Priority
Eq: net.sf.statcvs.model.VersionedFile defines compareTo(Object) and uses Object.equals() 176 Normal

net.sf.statcvs.model.Directory

Violation Line Priority
Eq: net.sf.statcvs.model.Directory defines compareTo(Object) and uses Object.equals() 204 Low

net.sf.statcvs.model.Repository

Violation Line Priority
EI: net.sf.statcvs.model.Repository.getLastDate() may expose internal representation by returning Repository.lastDate 102 Normal
EI: net.sf.statcvs.model.Repository.getFirstDate() may expose internal representation by returning Repository.firstDate 112 Normal

net.sf.statcvs.util.IntegerMap$SortByValueComparator

Violation Line Priority
Se: net.sf.statcvs.util.IntegerMap$SortByValueComparator implements Comparator but not Serializable -1 Normal

net.sf.statcvs.util.IntegerMap

Violation Line Priority
ICAST: int division result cast to double or float in net.sf.statcvs.util.IntegerMap.getPercentOfMaximum(Object) 117 Normal

net.sf.statcvs.charts.TimeBarChartMaker

Violation Line Priority
EI2: net.sf.statcvs.charts.TimeBarChartMaker.TimeBarChartMaker(ReportConfig, SortedSet, String, String, String[]) may expose internal representation by storing an externally mutable object into TimeBarChartMaker.barLabels 49 Normal

net.sf.statcvs.model.Commit

Violation Line Priority
Eq: net.sf.statcvs.model.Commit defines compareTo(Object) and uses Object.equals() 115 Normal

net.sf.statcvs.charts.LOCChartMaker$AllDirectoriesLOCChartMaker

Violation Line Priority
ICAST: int division result cast to double or float in net.sf.statcvs.charts.LOCChartMaker$AllDirectoriesLOCChartMaker.getImportance(Directory, Date, Date) 253 Normal

net.sf.statcvs.input.RevisionData

Violation Line Priority
EI: net.sf.statcvs.input.RevisionData.getDate() may expose internal representation by returning RevisionData.date 64 Normal
EI2: net.sf.statcvs.input.RevisionData.setDate(Date) may expose internal representation by storing an externally mutable object into RevisionData.date 71 Normal
UwF: RevisionData.revisionNumber not initialized in constructor -1 Low

net.sf.statcvs.input.RepositoryFileManager

Violation Line Priority
ST: Write to static field net.sf.statcvs.input.RepositoryFileManager.logger from instance method net.sf.statcvs.input.RepositoryFileManager.RepositoryFileManager(String) 54 Normal
RV: net.sf.statcvs.input.RepositoryFileManager.getLineCount(BufferedReader) discards result of readLine after checking if it is nonnull 81 Normal

net.sf.statcvs.input.Builder

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 255 Low

net.sf.statcvs.output.CommandLineParser

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 77 Low
EI2: net.sf.statcvs.output.CommandLineParser.CommandLineParser(String[]) may expose internal representation by storing an externally mutable object into CommandLineParser.argsArray 48 Normal

net.sf.statcvs.charts.CommitScatterChartMaker

Violation Line Priority
FE: Test for floating point equality in net.sf.statcvs.charts.CommitScatterChartMaker.createTimeSeries(SortedSet) 115 Low

net.sf.statcvs.reportmodel.HelperTimePoint

Violation Line Priority
Eq: net.sf.statcvs.reportmodel.HelperTimePoint defines compareTo(Object) and uses Object.equals() 117 Normal

net.sf.statcvs.reportmodel.TimePoint

Violation Line Priority
EI2: net.sf.statcvs.reportmodel.TimePoint.TimePoint(Date, int, int) may expose internal representation by storing an externally mutable object into TimePoint.date 45 Normal
EI: net.sf.statcvs.reportmodel.TimePoint.getDate() may expose internal representation by returning TimePoint.date 54 Normal

net.sf.statcvs.reports.FilesRevisionCountComparator

Violation Line Priority
Se: net.sf.statcvs.reports.FilesRevisionCountComparator implements Comparator but not Serializable -1 Normal

net.sf.statcvs.reports.FilesLocComparator

Violation Line Priority
Se: net.sf.statcvs.reports.FilesLocComparator implements Comparator but not Serializable -1 Normal

net.sf.statcvs.pages.xml.AllDevelopersXml

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 73 Low

net.sf.statcvs.pages.xml.FilesXml

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 97 Low
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 147 Low
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 194 Low

net.sf.statcvs.pages.xml.GenerateXml

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 51 Low

net.sf.statcvs.Main

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 66 Low

net.sf.statcvs.input.CvsRevisionParser

Violation Line Priority
UwF: CvsRevisionParser.revision not initialized in constructor -1 Low

net.sf.statcvs.reports.LOCSeriesBuilder

Violation Line Priority
UwF: LOCSeriesBuilder.minute not initialized in constructor -1 Low